Add fallback og:image #1192
Merged
Add fallback og:image #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We support setting an og:image when a page has a `meta_image` set in its front matter, but we don't have a fallback, so links to most pulumi.io pages currently don't have an image on Twitter. This fixes that by adding a fallback like the www site (and soon-to-be merged site).
chrsmith
approved these changes
Jun 18, 2019
![pulumi[bot]](https://avatars.githubusercontent.com/in/15540?s=60&v=4){kind=small}
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/pulumi.io/pulumi.io-staging was successful.
Resource Changes
Name Type Operation
~ reference/pkg/python/pulumi_aws/opsworks/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/kms/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/kubernetes/node/v1alpha1/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/python/pulumi_aws/securityhub/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/python/pulumi_gcp/composer/index.html aws:s3/bucketObject:BucketObject update
~ reference/tutorials/aws/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/kubernetes/scheduling/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/python/pulumi_gcp/spanner/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/python/pulumi_kubernetes/settings/v1alpha1/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/workspaces/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/kubernetes/autoscaling/v2beta2/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/python/pulumi_gcp/servicenetworking/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/python/pulumi_aws/dlm/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/glacier/index.html aws:s3/bucketObject:BucketObject update
~ reference/cli/pulumi_stack_import/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/awsx/acmpca/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/python/pulumi_aws/pinpoint/index.html aws:s3/bucketObject:BucketObject update
~ quickstart/gcp/next-steps/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/batch/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/cloudflare/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/digitalocean/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/resourcegroups/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/gcp/folder/index.html aws:s3/bucketObject:BucketObject update
~ reference/tutorials/aws/tutorial-service/index.html aws:s3/bucketObject:BucketObject update
~ quickstart/cloudfx/tutorial-service/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/sfn/index.html aws:s3/bucketObject:BucketObject update
~ quickstart/gcp/index.html aws:s3/bucketObject:BucketObject update
~ reference/config/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/backup/index.html aws:s3/bucketObject:BucketObject update
~ quickstart/aws/review-project/index.html aws:s3/bucketObject:BucketObject update
~ quickstart/cloudfx/tutorial-thumbnailer/index.html aws:s3/bucketObject:BucketObject update
~ reference/cli/pulumi_stack_rename/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/gcp/bigtable/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/kubernetes/certificates/index.html aws:s3/bucketObject:BucketObject update
~ reference/clouds/gcp/service-account/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/ec2transitgateway/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/cloudwatch/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/gcp/redis/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/aws/lightsail/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/f5bigip/ltm/index.html aws:s3/bucketObject:BucketObject update
~ reference/pkg/nodejs/pulumi/kubernetes/apiextensions/v1beta1/index.html aws:s3/bucketObject:BucketObject update
... and 838 other changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrsmith, this is a targeted fix for the current pulumi.io site per @aydrian so links to the current pulumi.io on Twitter have an image. The changes in
fusionalready has this addressed along with all the other metaogtag cleanup.We support setting an og:image when a page has a
meta_imageset in its front matter, but we don't have a fallback, so links to most pulumi.io pages currently don't have an image on Twitter. This fixes that by adding a fallback like the www site (and soon-to-be merged site).